Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Style edits for Concepts section #4550

Merged
merged 12 commits into from
May 28, 2024
Merged

Style edits for Concepts section #4550

merged 12 commits into from
May 28, 2024

Conversation

theletterf
Copy link
Member

@theletterf theletterf commented May 28, 2024 •
edited
Loading

Fixes #4551

Part of a site-wide sweep for style that I do when I've available cycles. Issues fixed include:

@theletterf theletterf requested a review from a team May 28, 2024 08:23
@theletterf theletterf self-assigned this May 28, 2024
@theletterf theletterf marked this pull request as draft May 28, 2024 08:30
@theletterf theletterf marked this pull request as ready for review May 28, 2024 08:33
chalin
chalin approved these changes May 28, 2024
View reviewed changes
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM, thanks! See inline for a few comments & suggestions.

content/en/docs/concepts/_index.md Outdated Show resolved Hide resolved
content/en/docs/concepts/components.md Outdated Show resolved Hide resolved
content/en/docs/concepts/glossary.md Outdated Show resolved Hide resolved
@chalin chalin mentioned this pull request May 28, 2024
Closed
@theletterf theletterf requested a review from chalin May 28, 2024 09:30
chalin
chalin approved these changes May 28, 2024
View reviewed changes
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for the extra glossary CSS style cleanup!

@chalin chalin merged commit 2f34c45 into main May 28, 2024
17 checks passed
@chalin chalin deleted the theletterf-concepts-style-edits branch May 28, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalin chalin chalin approved these changes

Assignees

@theletterf theletterf

Labels
copyedit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Glossary: avoid unnecessary use of code font for glossary entries
2 participants
@theletterf @chalin